Revert "chore: update libp2p to 0.52.1 (#14429)"

paritytech / substrate

Substrate: The platform for blockchain innovators

Apache License 2.0

8.39k stars 2.65k forks source link

Revert "chore: update libp2p to 0.52.1 (#14429)" #14722

Closed altonen closed 1 year ago

altonen commented 1 year ago

This reverts commit d38d176b844aab1338ce79eb71cd6df86c97d4a0.

polkadot companion: https://github.com/paritytech/polkadot/pull/7583 cumulus companion: https://github.com/paritytech/cumulus/pull/2975

altonen commented 1 year ago

@dmitry-markin

It's due to DHT issues we're experiencing on Versi. I'll get back to this upgrade soon enough but in the mean time we have to revert because I don't know how long it's going to take to figure out the underlying issues and there are other important tasks as well.

rphmeier commented 1 year ago

This should be merged, no?

As far as we know, libp2p 0.52.1 is broken and should be taken out of master ASAP, right?

altonen commented 1 year ago

This should be merged, no?

As far as we know, libp2p 0.52.1 is broken and should be taken out of master ASAP, right?

yeah, just missing one last review from cumulus companion

paritytech-cicd-pr commented 1 year ago

The CI pipeline was cancelled due to failure one of the required jobs. Job name: test-linux-stable Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3397107

bkchr commented 1 year ago

bot merge force

mxinden commented 1 year ago

Let me know in case you need any help debugging the v0.52.1 issues you are seeing.

Expanded on V1Lazy in https://github.com/paritytech/substrate/pull/14691#issuecomment-1675946673.
Setting set_mode(Mode::Server) will revert to the previous Kademlia behavior, though as one would expect, disables the Kademlia client mode optimization.

altonen commented 1 year ago

@mxinden cheers, I'll be in contact with you when I start working the upgrade again and if I can't figure out the issues.