search

paritytech / substrate

Substrate: The platform for blockchain innovators
Apache License 2.0
8.39k stars 2.65k forks source link

sc-cli: add no-beefy flag to cli config #14754

Closed acatangiu closed 1 year ago

acatangiu commented 1 year ago

BEEFY is soon expected to run on all substrate-based chains, make it part of sc-cli.

Note: in case of polkadot binary, CLI doesn't change. --no-beefy is moved from polkadot specific cli to sc-cli.

polkadot companion: https://github.com/paritytech/polkadot/pull/7600 cumulus companion: https://github.com/paritytech/cumulus/pull/2996

acatangiu commented 1 year ago

LGTM! I may also need a cumulus companion

You're right! done.

acatangiu commented 1 year ago

bot merge

bkchr commented 1 year ago

BEEFY is soon expected to run on all substrate-based chains

That is a bold statement that isn't true...

I know that we also have there disable_grandpa, that is just some old oversight and we should not replicate it.

acatangiu commented 1 year ago

BEEFY is soon expected to run on all substrate-based chains

That is a bold statement that isn't true...

I hope it will prove true 😛

I know that we also have there disable_grandpa, that is just some old oversight and we should not replicate it.

So you suggest we revert to having --no-beefy as a polkadot-specific CLI flag as opposed to sc-cli flag?

bkchr commented 1 year ago

So you suggest we revert to having --no-beefy as a polkadot-specific CLI flag as opposed to sc-cli flag?

Yes please. Not all Substrate chains are running grandpa either and the same will apply to beefy.