search

paritytech / substrate

Substrate: The platform for blockchain innovators
Apache License 2.0
8.39k stars 2.65k forks source link

Revert "sc-cli: add no-beefy flag to cli config (#14754)" #14766

Closed acatangiu closed 1 year ago

acatangiu commented 1 year ago

This reverts commit 2060c366fb1402deab188911551a43c3c41b36c0.

Based on https://github.com/paritytech/substrate/pull/14754#issuecomment-1677208626

polkadot companion: https://github.com/paritytech/polkadot/pull/7613 cumulus companion: https://github.com/paritytech/cumulus/pull/3007

acatangiu commented 1 year ago

@bkchr

I know that we also have there disable_grandpa, that is just some old oversight and we should not replicate it.

shall I also remove disable_grandpa then (remove --no-grandpa from sc-cli)? If yes, will do it as separate PR so that this is clean revert and nothing else.

bkchr commented 1 year ago

@bkchr

I know that we also have there disable_grandpa, that is just some old oversight and we should not replicate it.

shall I also remove disable_grandpa then (remove --no-grandpa from sc-cli)? If yes, will do it as separate PR so that this is clean revert and nothing else.

Sounds like a good idea! WDYT @andresilva?

acatangiu commented 1 year ago

bot merge

paritytech-processbot[bot] commented 1 year ago

Error: Github API says https://github.com/paritytech/polkadot/pull/7613 is not mergeable

andresilva commented 1 year ago

The disable_grandpa flag is used in both the node and node-template services, those are just using directly the RunCmd from sc-cli and it's probably not worth it to create their own RunCmd structs just for this. I'm fine with removing it, but it should still be added to polkadot IMO.

acatangiu commented 1 year ago

bot merge