`sp-core` build fails when depending on master branch

tobin-crypto commented 2 years ago

We are depending on sp-core master branch and there is currently a build failure caused by `tiny-bip39:

error[E0184]: the trait `Copy` may not be implemented for this type; the type has a destructor
   --> /home/tobin/.cargo/registry/src/github.com-1ecc6299db9ec823/tiny-bip39-0.8.0/src/language.rs:116:24
    |
116 | #[derive(Debug, Clone, Copy, PartialEq, Zeroize)]
    |                        ^^^^ Copy not allowed on types with destructors
    |
    = note: this error originates in the derive macro `Copy` (in Nightly builds, run with -Z macro-backtrace for more info)

Looking at the tiny-bip39 codebase it looks like the zeroize derive was removed so an upgrade to 0.8.1 should fix this.

Please Note; I didn't do a PR because I can't clone this repo. FTR here is the error when I tried to do so.

Cloning into '/home/tobin/build/github.com/paritytech/substrate'...
remote: Enumerating objects: 629848, done.
remote: Counting objects: 100% (22402/22402), done.
remote: Compressing objects: 100% (8351/8351), done.
remote: Total 629848 (delta 14493), reused 20904 (delta 13557), pack-reused 607446
Receiving objects: 100% (629848/629848), 372.77 MiB | 5.16 MiB/s, done.
Resolving deltas: 100% (411630/411630), done.
fatal: multiple updates for ref 'refs/remotes/origin/pr/7744' not allowed

thiolliere commented 2 years ago

the reason you can't clone is probably due to your gitconfig https://stackoverflow.com/questions/54922704/git-cloning-error-fatal-multiple-updates-for-ref-not-allowed

Which version of rust are you using ? we are using 0.8.0 and CI is successful.

bkchr commented 2 years ago

@tobin-crypto any update?

paritytech / substrate

`sp-core` build fails when depending on master branch #9841