paritytech / subxt

Interact with Substrate based nodes in Rust or WebAssembly
Other
391 stars 236 forks source link

Swap BinaryHeap for Vec to avoid Ord constraint issue #1523

Closed jsdw closed 3 months ago

jsdw commented 3 months ago

Substitute BinaryHeap for Vec in the same way that we do for BTreeMap/Set to avoid issues with the Ord constraint on the generic type (because this may be a generated type, and we don't automatically apply Ord to generated types).

Now that we have recursive derives, we might be able to be smarter about this sort of thing in the future by autoamtically recursively deriving Ord on the relevant types (which should be OK because it would very likely have existed on the ndoe side anyway to be using such types)

Closes #1515