Tweaks to eth signer - Githubissues

paritytech / subxt

Interact with Substrate based nodes in Rust or WebAssembly

Other

391 stars 236 forks source link

Tweaks to eth signer #1526

Closed jsdw closed 2 months ago

jsdw commented 2 months ago

@ryanleecode I finally got to having a pass over #1501 and thought I'd just suggest tweaks in the form of a branch! Lemme know what you reckon, and if all good then we can merge this into your PR and I reckon it's good to go :)

The tweaks:

Put behind unstable flag for now
Test in CI
Separate DerivationPath so that people can configure it more arbitrarily.
A couple of misc tweaks

jsdw commented 2 months ago

Ok, I added a test using some of the vectors in BIP39; these compare mnemonic + password vs seed.

In the process of doing this, I realised that our from_seed functions were a lie; they were actually "from secret key bytes". So I renamed them to from_secret_key_bytes and added a proper from_seed function here, which is then used in the new tests.

CI isn't running but we'll spot any issues once it merges with the other branch I guess!