search

paritytech / subxt

Interact with Substrate based nodes in Rust or WebAssembly
Other
411 stars 244 forks source link

Fixed import in `subxt-signer::eth` #1553

Closed muraca closed 5 months ago

muraca commented 5 months ago

fixes #1552

niklasad1 commented 5 months ago

hmm, most likely a merge conflict or something caused this.

Ideally we should check this in the CI but thank you :rainbow:

muraca commented 5 months ago

Ideally we should check this in the CI

I saw that the CI only does cargo check with the proper feature, it's weird that this problem is being shown when building only.

niklasad1 commented 5 months ago

It's re-producible with cd signer && cargo check --features unstable-eth as well.

It's probably that some features is leaked in our workspace that caused that to work in the CI or that the feature is not checked at all. Anyway thanks for the PR