paritytech / subxt

Interact with Substrate based nodes in Rust or WebAssembly
Other
391 stars 236 forks source link

Remove `derive_more` #1600

Closed pkhry closed 1 month ago

pkhry commented 1 month ago

Description

jsdw commented 1 month ago

Feel free to merge the two sub-PRs into this one; IMO it would be easier to see it all in one place, and you'll have to merge the others into here before we can properly review this one anyway!

I think I'd only normally stick to separate PRs when it's actually two distinct things that can both be merged to master independently :)

pkhry commented 1 month ago

Feel free to merge the two sub-PRs into this one; IMO it would be easier to see it all in one place, and you'll have to merge the others into here before we can properly review this one anyway!

I think I'd only normally stick to separate PRs when it's actually two distinct things that can both be merged to master independently :)

I initially made separate pr's to make reviewing easier, but good to know, i won't be splitting mr's in the future if they are changing the same thing