Closed pkhry closed 1 month ago
Feel free to merge the two sub-PRs into this one; IMO it would be easier to see it all in one place, and you'll have to merge the others into here before we can properly review this one anyway!
I think I'd only normally stick to separate PRs when it's actually two distinct things that can both be merged to master independently :)
Feel free to merge the two sub-PRs into this one; IMO it would be easier to see it all in one place, and you'll have to merge the others into here before we can properly review this one anyway!
I think I'd only normally stick to separate PRs when it's actually two distinct things that can both be merged to master independently :)
I initially made separate pr's to make reviewing easier, but good to know, i won't be splitting mr's in the future if they are changing the same thing
Description
From
fromderive_more
derive_more
from dependenciesQuestions:
Given that we used
derive_more
for errors, maybe we can use SNAFU for errors with no-std constraint given thatthiserror
doesn't support no-std see #1503