Open hbulgarini opened 1 year ago
Line 329: IMPORTANT: I would disable random users from sending arbitrary xcm messages to any destination.
@vstam1 i would like to touch point on this one:
How is the recommended configuration for the SendXcmOrigin if for example we want to implement a solution like the one described bellow:
https://github.com/paritytech/xcm-docs/issues/34#issuecomment-1604084490
Just for tracking as I don't fully understand yet if it's on us but currently WithComputedOrigin
on Barrier
blocks incoming reserve asset transfer
of HOP from Asset Hub.
However, reserve asset transfer
of ROC from Asset Hub into Trappist, works.
@vstam1 shared the following inputs for the Trappist XCM configuration:
Line 62: Can't we remove Ancestry? Its never used.
Line 136: Could use the ConvertedConcreteId instead of ConvertedRegisteredAssetId. I can understand that the name makes more sense then ConvertedConcreteId in this case but could also create seperate type ConvertedRegisteredAssetId = ConvertedContreteId<...> to prevent code duplication. I think Gavin did change the trait bounds in 0.9.43 or still just master from Convert -> MaybeEquivalence but think that the 0.9.42 still has the old trait bounds. Still just a suggestion, can keep it as is.
Line 201: Might be able to use RockmineLocation.
Line 329: IMPORTANT: I would disable random users from sending arbitrary xcm messages to any destination.
General: Might be good to change from Rockmine to RococoAssetHub
https://github.com/paritytech/trappist/issues/240#issuecomment-1662028228