search

paritytrading / philadelphia

Fast FIX protocol library for the JVM
Apache License 2.0
322 stars 95 forks source link

Improve handling of logon acknowledgements if msgSeqNum != rxMsgSeqNum #320

Closed dmech closed 1 year ago

dmech commented 1 year ago

See #315

dmech commented 1 year ago

Thank you @jvirtanen :+1: , I will add some tests

dmech commented 1 year ago

Sorry, I messed things up while syncing my fork to main. This pull request should not have been closed. I will probably have to create a new one.

jvirtanen commented 1 year ago

I think you can reopen it just by pushing to the original branch, main. 🙂

dmech commented 1 year ago

Thank you @jvirtanen :raised_hands: I keep learning. All your 'Nits' are legit points. I leave it to you to resolve the conversations.