pariyatti / kosa

Digital library service
GNU Affero General Public License v3.0
8 stars 3 forks source link

add the default 600 seconds wait_for_connection #69

Closed balwa closed 1 year ago

balwa commented 2 years ago

add the default 600 seconds wait_for_connection for new host dns propagation

balwa commented 1 year ago

I think this is fine to merge, but I have two questions:

  1. In the Ansible docs, the key is ansible.builtin.wait_for_connection: ... is there a reason we don't need to fully qualify it like that?

You are right, I was looking at the old documentation. The latest recommendation is to use ansible.builtin.wait_for_connection. Updated the module name.

  1. Should we set a non-default timeout so it's obvious to a reader how to adjust it? Or am I overthinking that bit? ;)

I had the exact same thought, of just defining even if it is default, the value, so that it's easier to adjust the value in future. So added that parameter as well 👍