search

pariyatti / kosa

Digital library service
GNU Affero General Public License v3.0
8 stars 3 forks source link

Add GitHub actions test for master branch #86

Closed balwa closed 1 year ago

balwa commented 1 year ago

Currently enabling only on master branch push activity. Tests are failing currently on latest master even in local, so github actions marks them as failed as well. Though the tests seem to be running in ubuntu 20.04 env without issues.

balwa commented 1 year ago

Not that it's a problem, particularly, but is there a reason for choosing Zulu over OpenJDK? We probably want to run the tests in the same environment/JDK we run in production... though we could very well switch over to Zulu there as well.

Yeah, openjdk is a better option, just for consistency. Let's switch to openjdk 🙂