park-bench / netcheck

Finds the best network with access to the Internet.
GNU General Public License v3.0
0 stars 0 forks source link

Break netcheck.py's Logic Into Multilple Modules #25

Open eviljoel opened 5 years ago

eviljoel commented 5 years ago

netcheck.py is too large and hence is confusing to read. We should probably create a Connection class which contains the logic related to a connection. This Connection class would be adhering to the object oriented design pattern. With Parkbench, we don't typically do true object oriented design, but in this case I think it would make sense.

I'm not 100% sold on doing the Connection class. If you can find a better way to break up the logic, feel free to implement it that way.