search

parker-codes / coda-js

An eloquent Node API for interacting with your Coda Docs.
39 stars 9 forks source link

V1 migration Issues 1 to 4 #15

Closed phlexib closed 4 years ago

phlexib commented 4 years ago
  1. update request path to use v1 inAPI.ts
  2. we didn't have a views API before so users can just use the table API 😂
    • note the new tableType property in models/Table.ts comment
    • add something to README examples that shows tableType can be access to tell if it's a table or view
  3. remove all references to Folders API
  4. convert all references of Sections to Pages (eg. getPage(...) instead of getSection(...))
parker-codes commented 4 years ago

Hey @phlexib, thanks for contributing! I'll review this soon!

phlexib commented 4 years ago

Hi, thanks for the comments , it's my first PR so I totally welcome all of your comments. The code-style changes are my ESLint settings on auto-save. I noticed it changed all the single quote to double quote and fixed it. But I didn't think the multilines would be a problem. Sorry

phlexib commented 4 years ago

Here's a new commit with all your note : v1-migration

parker-codes commented 4 years ago

@phlexib It looks great. Thanks again! 😁

parker-codes commented 4 years ago

@phlexib I actually reverted the merge. The code still looks good, but I realized that you had the PR pointing to the master branch. Could you create a new PR from your v1-migration branch to this repos v1-migration branch?