parkouss / webmacs

webmacs - keyboard driven (emacs key bindings) browser, https://webmacs.readthedocs.io/en/latest/
GNU General Public License v3.0
157 stars 21 forks source link

Logo for desktop icons #139

Open salotz opened 3 years ago

salotz commented 3 years ago

Was annoyed at not having a desktop icon so I made one (I also have svg), let me know if you'd want to include it.

webmacs icon

I also wrote a .desktop file but I'm sure its crappy. Will make PR if I get some confirmation.

[Desktop Entry]
Name=Webmacs
GenericName=Emacs like web browser
Comment=View HTML and web pages
MimeType=application/pdf;application/rdf+xml;application/rss+xml;application/xhtml+xml;application/xhtml_xml;application/xml;image/gif;image/jpeg;image/png;image/webp;text/html;text/xml;x-scheme-handler/ftp;x-scheme-handler/http;x-scheme-handler/https;
Exec=webmacs %F
Icon=webmacs
Type=Application
Terminal=false
Categories=Network;WebBrowser;
Keywords=Text;Editor;
TLATER commented 3 years ago

Love the icon, it's awesome!

I think I'd change this, looking at what the spec has to offer:

[Desktop Entry]
GenericName=Web Browser  # These are somewhat standardized and used for matching, so let's match Firefox's
Comment=Keyboard driven (emacs key bindings) browser, https://webmacs.readthedocs.io/en/latest/  # Let's use our actual flavor text
TryExec=webmacs  # TryExec is always nice to add
Keywords=emacs;keyboard;driven;  # This is not a text editor...

We can also consider defining Actions that use the -i and -p flags :)

salotz commented 3 years ago

Lol glad you like it! hahaha rotate E and recolor :P

How about this. It passed desktop-file-validate and seems to be working for me on Ubuntu 16 GNOME:

[Desktop Entry]
Name=Webmacs
GenericName=Web Browser
Comment=Keyboard driven (emacs key bindings) browser, https://webmacs.readthedocs.io/en/latest/
MimeType=application/pdf;application/rdf+xml;application/rss+xml;application/xhtml+xml;application/xhtml_xml;application/xml;image/gif;image/jpeg;image/png;image/webp;text/html;text/xml;x-scheme-handler/ftp;x-scheme-handler/http;x-scheme-handler/https;
Exec=webmacs %F
TryExec=webmacs
Icon=webmacs
Type=Application
Terminal=false
Categories=Network;WebBrowser;
Keywords=emacs;keyboard;driven;

I was adding a profile action but I'm not sure you can parametrize it then with just strings.

TLATER commented 3 years ago

LGTM - actions are definitely a bit of a stretch goal, we'd need to make the "new window" or "new buffer" things a bit more obvious from the CLI, and have a hardcoded "private" profile or somesuch. So let's discuss that in a different ticket.

For now I'd love to see a PR for this .desktop and that icon!

Just check we have some attribution and maybe ping Emacs upstream to see if we're ok with that icon. Both us and Emacs are GPL, but the icon might be a different story; altough I can't imagine we would not be allowed this :)

parkouss commented 1 year ago

Hi there, I'm back in the game to maintain this project on my free time. The icon is really nice, feel free to make a PR. :)