fix COPY_METADATA env usage with script

danleyb2 commented 3 months ago

include copy_metadata param only when set to true

github-actions[bot] commented 3 months ago

Risk Level 2 - /home/runner/work/deep-license-plate-recognition/deep-license-plate-recognition/blur/main.py

The changes include adding a new feature to copy metadata and handling API keys for authorization. Here are some suggestions:

Ensure that the args.copy_metadata flag is properly documented and tested, as it affects the data payload.
When handling API keys, it's crucial to ensure they are not logged or exposed in any way. The current changes do not directly expose the API key, but be cautious with logging around areas where the API key is used.
The error handling for the response status code could be more robust. Consider using response.raise_for_status() for a more concise approach:
```
try:
   response.raise_for_status()
except requests.exceptions.HTTPError as err:
   raise BlurError(f\"HTTP error occurred: {err}\")
```
The process function is becoming complex. While not requested to break down functions, consider if future changes might necessitate this for maintainability.

🔒📝🛠️

🔒 (Security): Caution with handling API keys to prevent exposure.
📝 (Documentation/Testing): Ensure proper documentation and testing of the new args.copy_metadata feature.
🛠️ (Code Quality): Suggestions for improving error handling and considering refactoring for maintainability.

marcbelmont commented 3 months ago

@danleyb2, merge if no further edits are needed.

parkpow / deep-license-plate-recognition