Closed parkr closed 6 years ago
can the message be simplified to: ?
- ... jekyll/minima would have been nudged for date=2017-04-13 15:05:31 +0000 UTC commits=17
+ ... jekyll/minima would have been nudged on 2017-04-13 15:05:31 +0000 UTC for 17 commits
Could @jekyllbot create an issue after two months or after a configurable amount of commits per repo?
👋 Hi maintainers,
Time to push a new release of {{ repo.name}} !
💎 {{ repo.latest_release }} was released {{ days_since_release }} days ago and {{ commits_since_latest_release }} commits have been added since.
...
We already have unreleased commits on https://dashboard.jekyllrb.com/, we could also had latest release date there in relative format (eg. 1 month ago).
@ashmaroli The output just goes to the Heroku logs, so it's not important how it's formatted (none of us will see it unless something went horribly wrong). The date there is the CreatedAt date, so for
makes more sense to me, because it wouldn't be nudged on a given date, it'd be nudged because a given date is over 2 month old, etc.
@DirtyF Why configure per-repo?
@parkr If we only do +2months for all repos, I don't think we'll release e.g, jekyll-sass-converter
updates as often as jekyll
. We can do without custom release cycle for now, it's already a huge help to be able to have reminders about releases. 🎗
Next step: automated date-based releases? 📆
@parkr If we only do +2months for all repos, I don't think we'll release e.g, jekyll-sass-converter updates as often as jekyll. We can do without custom release cycle for now, it's already a huge help to be able to have reminders about releases. 🎗
The date check ensures that there is at least 1 unreleased commit. I'd argue jekyll-sass-converter could be released more quickly than jekyll, so leaving any unreleased commits is work that our users aren't benefitting from. I think 2 months of no release is a good threshold when there are changes to go out! It won't file the issue if there have been 0 commits on master since the last release.
because it wouldn't be nudged on a given date, it'd be nudged because a given date is over 2 month old
makes sense :+1:
It's working fine 😄
The purpose of this command is simply to nudge maintainers towards good release cycles of at minimum every 2 months when new commits have come in.
Current output:
/cc @ashmaroli @dirtyf @mattr- @pathawks