search

parlance / ctcdecode

PyTorch CTC Decoder bindings
MIT License
829 stars 245 forks source link

Potential memory leak #14

Closed ryanleary closed 7 years ago

ryanleary commented 7 years ago

Check bindings to ensure that all dynamically allocated memory is properly freed when no longer needed.

SeanNaren commented 7 years ago

@joshemorris is investigating this!

ryanleary commented 7 years ago

I can provide a couple pointers -- there are definitely a couple issues with the bindings in this regard, but should be easy to fix. It's really only going to be an issue if multiple decoders are created and released in a given python session.

joshemorris commented 7 years ago

Cool, thanks Ryan! Anywhere in particular you suggest I start looking? I figure anything loaded via virtual methods will need to be released. I was gonna start with that.