parley-messaging / android-library

Parley Android app library
MIT License
3 stars 3 forks source link

Fix: crash when showing the 'agent typing' message #11

Closed Rolf-Smit closed 2 years ago

Rolf-Smit commented 2 years ago

This crash was caused by referencing a styleable index that is not available in the requested styleable:

java.lang.UnsupportedOperationException: Can't convert value at index 15 to dimension: type=0x1
        at android.content.res.TypedArray.getDimensionPixelSize(TypedArray.java:787)
        at nu.parley.android.util.StyleUtil.getDimension(StyleUtil.java:100)
        at nu.parley.android.util.StyleUtil.getSpacingData(StyleUtil.java:91)
        at nu.parley.android.view.chat.holder.AgentTypingMessageViewHolder.applyStyle(AgentTypingMessageViewHolder.java:62)
        at nu.parley.android.view.chat.holder.AgentTypingMessageViewHolder.<init>(AgentTypingMessageViewHolder.java:32)
        at nu.parley.android.view.chat.MessageViewHolderFactory.getViewHolder(MessageViewHolderFactory.java:41)
        at nu.parley.android.view.chat.MessageAdapter.onCreateViewHolder(MessageAdapter.java:31)
        at nu.parley.android.view.chat.MessageAdapter.onCreateViewHolder(MessageAdapter.java:18)
        at androidx.recyclerview.widget.RecyclerView$Adapter.createViewHolder(RecyclerView.java:7078)
        at androidx.recyclerview.widget.RecyclerView$Recycler.tryGetViewHolderForPositionByDeadline(RecyclerView.java:6235)
        at androidx.recyclerview.widget.RecyclerView$Recycler.getViewForPosition(RecyclerView.java:6118)
        at androidx.recyclerview.widget.RecyclerView$Recycler.getViewForPosition(RecyclerView.java:6114)

It would be really helpful if this can be fixed/merged/released ASAP, since this is something that is 100% reproducible for all users.

alexkok commented 2 years ago

Thanks! We will create and release 3.4.3 today, which will contain this fix.

alexkok commented 2 years ago

Released in version 3.4.3 🚀

Rolf-Smit commented 2 years ago

Thanks!