parley-messaging / android-library

Parley Android app library
MIT License
3 stars 3 forks source link

Also publish on Maven Central instead of just Jitpack #23

Closed Rolf-Smit closed 1 year ago

Rolf-Smit commented 1 year ago

Currently this library is published to Jitpack, this has a few downsides but most importantly the up-time track-record for Jitpack is well... not the greatest as this issue proves: https://github.com/jitpack/jitpack.io/issues/5337

I also noticed that this library itself is defining a transitive dependency on: https://github.com/MikeOrtiz/TouchImageView which is also using Jitpack (thus also fails when Jitpack is down).

So I think it is best to migrate or also publish this library in a more reputable repository such as Maven Central, the transitive dependency is harder to solve, maybe there are other libraries that could be used instead that are published in Maven Central as well (or bundle it instead of making it a transitive dependency)?

Speiger commented 1 year ago

@Rolf-Smit serious question, since my library is also on jitpack. Maven-Central can be a pain to use. Can you provide another maven thats as easy to use as Jitpack?

And then you wouldn't even need to request this since jitpack allows you to use their service without being the owner of the repository, as long it is public

alexkok commented 1 year ago

Thanks for reporting @Rolf-Smit. Is this something you face a lot? JitPack will likely improve on this as well on their side.

As you also mentioned, to support Maven Central (or any other method), we'll need to check or replace the other dependency as well.

We will probably consider adding other methods as well in the future. However, for now we'll keep using JitPack.

Feel free to let us know if you face issues with this again.