search

parley-messaging / android-library

Parley Android app library
MIT License
3 stars 3 forks source link

Prevent NPE for call parleyErrorResponse.getNotification #40

Closed diederv closed 4 months ago

diederv commented 4 months ago

Our proxy currently doesn't return the right (read: expected) json error structure, this results in a crash. This change will prevent that crash. We'll need to deal with handling the errors but first we'll need to prevent the crash. It would be cool if you could merge this into master and bump to >3.9.3

Kind Regards, Diederick Kotlin/Android developer Triodos

alexkok commented 4 months ago

Thanks for reporting.

However, since the notifications field shouldn't be nullable, we'll likely revert this change in a later version (so make sure the proxy returns at least the response/fields that Parley expects to prevent this from breaking later).

For now we'll merge and release it in 3.9.3 👍

diederv commented 4 months ago

Alex, thank you for your consideration. We'll need to find a proper solution for this problem. For now I'm happy with your release.

alexkok commented 4 months ago

Released in 3.9.3 🚀