search

parley-messaging / android-library

Parley Android app library
MIT License
3 stars 3 forks source link

Optionally disable send button #51

Open LauBCra opened 1 month ago

LauBCra commented 1 month ago

Make disabling the send button optional. We would like to always enable the send button. From a style perspective, the disabled alpha is a hue that we don't use in our app.

But more so, it's unclear for accessibility users why the button is disabled. We aim to always enable buttons for clarity. Currently the screenreader user gets no feedback about the state of the button, which isn't a problem if the button is always enabled.

alexkok commented 1 month ago

Thanks for the request, a question for full clarity about this one: What would you expect/want to have as result when always enabling the send button, and the user clicking the button while there is no message to be send? (Clicking the button when the input field has no text)

LauBCra commented 1 month ago

For visual users having the placeholder there and when clicking the button nothing happens should be ok. The placeholder is enough of a hint to what should happen. For screenreader users we like to give them a hint when clicking the button, in this case something like 'please type a message', just to help them along a bit.