parley-messaging / ios-library

Parley iOS app library
MIT License
2 stars 2 forks source link

Image detail not always loading #114

Closed nlamah closed 4 months ago

nlamah commented 4 months ago

Describe the bug When pressing an image from the chat a modal screen opens and the full image can be viewed and zoomed. For some reason the image is not always loading without showing a loader or error.

To Reproduce NB: this is not 100% reprodocible, but

Expected behaviour There should be a loader visible when the image is being loaded, when the image can't be loaded an error should be shown.

Screenshots

https://github.com/parley-messaging/ios-library/assets/2762698/7279f8a9-471f-4516-8166-b7d742e44b0a

nlamah commented 4 months ago

With the debugger I was able to reproduce that it is caused by the widthScale and heightScale, being zero. The image was loaded correctly. Screenshot 2024-05-30 at 13 54 52

alexkok commented 4 months ago

Fixed and released in 4.1.1 🚀