search

parley-messaging / ios-library

Parley iOS app library
MIT License
2 stars 2 forks source link

Bugfix/detail image not always loading #116

Closed nlamah closed 1 month ago

nlamah commented 1 month ago

Fix for issue: https://github.com/parley-messaging/ios-library/issues/114

nlamah commented 1 month ago

@alexkok There is a regression on the develop branch with the linkFont. One of the screenshots has italic link font, but now it is a regular font: https://github.com/parley-messaging/ios-library/pull/116/commits/96f04570a862ea3da3d276764ca23b4f68ce6579#diff-dc2bed7a29e5eba86950c2fe8a715d38154d929e84a7ddd3e35db33c43feec02 See this commit: https://github.com/parley-messaging/ios-library/pull/116/commits/96f04570a862ea3da3d276764ca23b4f68ce6579 There is also a difference in the left time padding, for example here: https://github.com/parley-messaging/ios-library/pull/116/commits/96f04570a862ea3da3d276764ca23b4f68ce6579#diff-2e0b784c05c35b1bdcc43355abdfbc42f7583b28f4f0870ba0a1c2e40cb7a784

alexkok commented 1 month ago

I see, thanks for pointing that out! We should fix those (happened when fixing another issue).

Although this PR focuses on the image detail bug, we'll merge this one. But the 2 regressions need to be looked at before release 👍

alexkok commented 1 month ago

Released in 4.1.1 🚀