Remove observers on config reset;

parley-messaging / ios-library

Parley iOS app library

MIT License

2 stars 2 forks source link

Closed mat1th closed 3 weeks ago

mat1th commented 3 weeks ago

In the following situation the SDK could crash

Parley.configure is called
Parley.purgeLocalMemory is called
App moves to the background
App moves to the forground
The registerDevicecall will create a fatal error because the secret is not set anymore. ParleyRemote.createHeaders#37.

To solve this issue the observers also need to be removed in the reset and purgeLocalMemory functions.

mat1th commented 3 weeks ago

@alexkok could you review this pr and create a new release? We do see this issue in production.

alexkok commented 3 weeks ago

Sure, looks good. On it! 👍

alexkok commented 3 weeks ago

Released in 4.1.8 🚀