Closed mat1th closed 5 months ago
Thanks for this PR @mat1th! We'll review and test the functionality with these changes soon. Also keeping backwards compatibility in mind.
In the meantime, you'll be able to rebase to develop
now, which contains the other 3 PR's now.
If I have done it correctly there should no breaking changes. I've tried to mimic the objectMapper logic. So if you find any regressions please let me know so I can fix them.
Thank you for merging the other pr's. I did a rebase this branch from develop and also pointed this branch to develop now.
Released in 3.9.0 🚀
This PR removes the dependency ObjectMapper. Which resolves the open issue #21.
Contents of pr:
ObjectMapper
in swift package and Podfile's.Codable
instead toMappable
ObjectMapper
withAlamofire
. And support for the mapping of a specific key in DataRequest+responseDecodableAtKeyPath.swiftI'm not able to fully test all functionality. With this code I'm able to send test messages with the demo app in the repo.
This pr depends on https://github.com/parley-messaging/ios-library/pull/51 but I can not base it on that one. Will rebase it that pr is merged.