search

parley-messaging / ios-library

Parley iOS app library
MIT License
2 stars 2 forks source link

SDK contains multiple memory leaks; #57

Closed mat1th closed 7 months ago

mat1th commented 8 months ago

Describe the bug I'm trying the demo app that is included in the project. When starting and stopping the chat the shown ParleyView and other view objects do stay in memory. This is caused multiple memory leaks.

To Reproduce

  1. Start the example app.
  2. Open a new chat.
  3. Stop the chat.
  4. Open a new chat.
  5. Stop the chat.
  6. Open a new chat.
  7. Stop the chat.
  8. Open "Debug memory graph" in Xcode.
  9. See multiple instances of theParleyView object in memory.

Expected behaviour I do expect that the SDK does deinit the view when it is dismissed.

Screenshots

memory
alexkok commented 8 months ago

Thanks for reporting! We'll look into it

mat1th commented 8 months ago

Thank you, I've already fixed some in https://github.com/parley-messaging/ios-library/pull/58, but there are more.

mat1th commented 8 months ago

Great thank you for fixing @martijnvdwal!

alexkok commented 7 months ago

Released in 3.9.1 🚀