search

parley-messaging / ios-library

Parley iOS app library
MIT License
2 stars 2 forks source link

Make it possible to hide the pushDisabledNotificationView #73

Closed mat1th closed 4 months ago

mat1th commented 4 months ago

Describe the feature We would like to hide the message in the chat view that indicates the push notification authorization status. Right now this message is shown/hidden based on the phone settings but we would like to be more in control over when we inform the user about push. Right now we can't change anything about this logic in the chat view, so we need to change the SDK.

Possible solution A rather quick solution could be to make @IBOutlet weak var pushDisabledNotificationView: ParleyNotificationView! public so we can hide it.

alexkok commented 4 months ago

Thanks for describing the request clearly!

Making the view public wouldn't be ideal I think, since showing/hiding it is done in different cases.

We'll probably make it an option in the Appearance structure that we have in place, I'll come back on that.

(And when hiding it, we'll assume that the app will inform the user about it being disabled where needed.)

mat1th commented 4 months ago

Agree that making it public is not a ideal solution. Sounds like a good plan to make it part of the Appearance structure. Thank you for looking into it! Yes we will inform the user our self that push is disabled.

alexkok commented 4 months ago

Fixed in #74 , will be released with 4.0.0 🚀

(use appearance.pushDisabledNotification.show = false to disable showing this view)

mat1th commented 4 months ago

Hi @alexkok, Great! Thank you for fixing it so fast!

alexkok commented 3 months ago

No problem!

Released in 4.0.0 🚀