parmentelat / jupyterlab-gridwidth

BSD 3-Clause "New" or "Revised" License
9 stars 2 forks source link

gridwidth does not render in preview for jupyterlab_rise #15

Closed Chilipp closed 7 months ago

Chilipp commented 7 months ago

Hey! thanks a lot for this great project! I was waiting for somthing like this. I mainly used the splitcell-extension in presentations that I created with rise, there is just worked out-of-the-box. rise however now moved to jupyterlab_rise and the developers explicitly stated in https://github.com/jupyterlab-contrib/rise/issues/1 that the split-cell classic extension is out-of-scope for jupyterlab_rise (which makes sense). I was hoping thatjupyterlab-gridwidth fills this gap here, but it did not render the columns in the presentation (see right tab in the screenshot)

image

To reproduce the setup here, you can use the example notebook from the jupyter-contrib/rise repo via

git clone https://github.com/jupyterlab-contrib/rise.git
cd rise
python -m venv venv
source venv/bin/activate
pip install jupyterlab jupyterlab_rise jupyterlab-gridwidth
jupyter server extension enable jupyterlab_rise
jupyter server extension enable jupyterlab-gridwith

start the server via jupyter lab and open the notebook at examples/README.ipynb

I am not an expert with developing externsions for jupyterlab. But do you think, such a rise-setup can be supported by jupyterlab-gridwidth? Or is this out-of-scope for your package?

thanks again for your efforts in this!

parmentelat commented 7 months ago

hey there ! nice to see that this tool can be useful

as far as rise: I made a very rough first diagnosis and it seems that the cell tag 'gridwidth-1-2' does not get applied as a css class on the html element

mind you: the lib actually responsible for applying css classes based on cell tags is actually https://github.com/parmentelat/jupyterlab-celltagsclasses so this is probably where the conversation should take place

will follow-up there

parmentelat commented 7 months ago

on a side note, I don't think you need to explicitly do these

jupyter server extension enable jupyterlab_rise
jupyter server extension enable jupyterlab-gridwith

as in my case at least the pip install ..s do the trick just fine