parmentelat / jupyterlab-gridwidth

BSD 3-Clause "New" or "Revised" License
9 stars 2 forks source link

redefine keyboard shortcuts ? #3

Closed parmentelat closed 10 months ago

parmentelat commented 10 months ago

as per @firezym the current choice of keyboard shortcuts is suboptimal as it is conflicting with predefined ones in the context of chrome/windows

firezym commented 10 months ago

Good idea. I am not sure which one to use. Maybe to align with ctrl+shift+c in windows, I suggest you could consider ctrl+shift+num :)

parmentelat commented 10 months ago

I'd rather stay way from ctrl+shift combos, as this tends to hurt my left pinky rather badly over time :) would it make sense to use Alt instead of Ctrl - everything else being equal for example can you bind Alt-\ Alt-1 Alt-2 are there any foreseeable conflicts if we we go down this road ?

firezym commented 10 months ago

You are totally right lol... ctrl+shift+num is too painful for hands >.< I have checked that alt+num is not occupied currently by windows chrome or windows system. I don't see much trending to asign alt+num as core hotkeys for chrome or windows. Conflicts might not be a near future problem :) We could go down this road and it's very convinient and smooth for hands!

parmentelat commented 10 months ago

all right, so that'll be the plan then I will probably not have a chance to do this in the neat future though; I suggest for starters you do the binding of 1/2 locally on your setup, so you can have hands-on experience and comment back her to confirm it's a convenient enough choice

firezym commented 10 months ago

I am majorly focusing on data analysis, not familiar with frontend development, just start to learn about it. But I will try to play around it with you code. Thanks a lot for your implementation :)

firezym commented 10 months ago

4

Please check: hotkeys change from ctrl+num to alt+num pull request.

parmentelat commented 10 months ago

first step in this direction is made in #4

let's see on the longer run if further work is needed to allow for more customization and cope with yet unforeseen setups

parmentelat commented 10 months ago

done in #4 and available in 0.1.3