Fix reported TooltipScanning error from reputation

parnic / LibDogTag-Unit-3.0

2 stars 1 forks source link

Fix reported TooltipScanning error from reputation #16

Closed parnic closed 1 month ago

parnic commented 1 month ago

I'm not sure why an index that's within range of GetNumFactions would return nil data from GetFactionDataByIndex, so we probably need to figure out what's up with that. Maybe the value returned by GetNumFactions is only a valid input in some other GetFactionDataBy variant?

Ref:

https://www.wowace.com/projects/ice-hud/issues/366
https://www.curseforge.com/projects/5394?comment=7333

parnic commented 1 month ago

This was added in 2641d29079c69ca7f43e0b93de92e4184f89a4c2 so I figured @ascott18 may want to look it over.

parnic commented 1 month ago

It does look like Blizzard uses this same pattern, so 🤷 https://github.com/Gethe/wow-ui-source/blob/c0f3b4f1794953ba72fa3bc5cd25a6f2cdd696a1/Interface/AddOns/Blizzard_UIPanels_Game/Mainline/CharacterFrame.lua#L193-L199