search

parnic / node-screenlogic

Pentair ScreenLogic Javascript library using Node.JS
https://www.npmjs.com/package/node-screenlogic
MIT License
53 stars 15 forks source link

Set heat mode #13

Closed mikemucc closed 4 years ago

mikemucc commented 4 years ago

I saw the functions to set the heater Set Point, but there wasn't any functionality to actually turn set the heater modes. This PR implements this functionality, so now you can set heat point and actually set the heater to the desired mode.

The file heatmodetest.js is just a quick test of the functionality with my system, which I've proved works both with software and by walking out to my equipment pad. :-) I left it in for testing, but I am happy to remove it prior to merging.

README.md also updated to reflect the new functionality.

mikemucc commented 4 years ago

@parnic Not sure how public github is about notifying on PRs, so tagging you.

parnic commented 4 years ago

LGTM, thanks for the contribution!

mikemucc commented 4 years ago

You bet. Does the NPM module auto-update or is there something that has to be done for that?

parnic commented 4 years ago

I have to tag a new version and push an update. I can probably do that in a few days when I'm back home.