search

parnic / node-screenlogic

Pentair ScreenLogic Javascript library using Node.JS
https://www.npmjs.com/package/node-screenlogic
MIT License
53 stars 15 forks source link

BugFix: gatewayName message.toString() conversion was stripping final character #14

Closed mikemucc closed 4 years ago

mikemucc commented 4 years ago

Found a small bug with gatewayName, I noticed it was stripping the final character. Increased the range from 28 to 29 and it fixed the issue.

@parnic

parnic commented 4 years ago

Interesting, not sure how I never caught this. Thanks!

mikemucc commented 4 years ago

Well, I've now got a REST api wrapped around this, and I'm seeing my system name every time I hit the API, and after a while I noticed "I'm missing a character on this... Hmmm". Probably took me over a month to notice.

schemers commented 4 years ago

can you publish a 1.3.1 module with this fix? I'm messing around with Homebridge and was planning on using the discovered name to help compute a persistent id. I've worked around for now, but would nice. thanks!

mikemucc commented 4 years ago

Agreed. I'm about to do a release of my Screenlogic API and Angular UI as well and would prefer to include 1.3.1 as the dependency. @schemers You might be interested in this as well: https://github.com/mikemucc/screenlogic-api, especially if it can be integrated to homekit.

parnic commented 4 years ago

Pushed.