Updated Readme / Added EggTimer Support

parnic / node-screenlogic

Pentair ScreenLogic Javascript library using Node.JS

https://www.npmjs.com/package/node-screenlogic

MIT License

52 stars 14 forks source link

Updated Readme / Added EggTimer Support #25

Closed bshep closed 4 years ago

bshep commented 4 years ago

Added 'EggTimer' support, the function is called setCircuitRuntimeById
Updated readme with information about the new functions

parnic commented 4 years ago

Hey @bshep, as soon as the review comments are addressed, I'm happy to merge this.

mikemucc commented 4 years ago

So glad to see more functionality getting added!

Commenting so that Github will let me know when this gets merged.

@parnic are you planning to do an npm deploy after this gets merged? When you do, we're going to start incorporating this into my API.

parnic commented 4 years ago

@mikemucc FYI you can subscribe to an issue without commenting :).

I can update the npm package whenever, sure.

mikemucc commented 4 years ago

Or course ;-) I also wanted to show my support to @bshep, so cool to see more functionality getting added.

This could potentially become a full replacement for Pentair's apps. And as Pentair has decided not to support 64-bit mac (or mac at all truthfully, as their app is just the windows version running under Wine), the sooner the better.

...now, does anybody know anything about electron?

bshep commented 4 years ago

Hey @bshep, as soon as the review comments are addressed, I'm happy to merge this.

Hmmm not sure which comments you mean? The CI checks seem to have passed? I think its an issues with the way i committed things to git, do you have any suggestions on how to fix it?

bshep commented 4 years ago

I think i fixed them... sorry about the missing explanations, copy-paste error ;-)