parnic / node-screenlogic

Pentair ScreenLogic Javascript library using Node.JS
https://www.npmjs.com/package/node-screenlogic
MIT License
52 stars 14 forks source link

Update readme methods #69

Closed tagyoureit closed 1 year ago

parnic commented 1 year ago

From the original PR (I didn't read the Readme changes as closely as I should have), the top of the Readme says this:

All of the previous events are still present and should still be added to the listeners

This is not accurate (one example is that poolStatus is now equipmentState) and should be changed. I don't mind doing that after taking this PR, but wanted to mention it in case it was unintentional.

parnic commented 1 year ago

These notes, and the review suggestions, are for me to remember after merging the PR.

And I need to spend time looking over the rest.