Closed tagyoureit closed 1 year ago
These notes, and the review suggestions, are for me to remember after merging the PR.
messageId
property into action
.balance
property..data
or .get()
. (This is inconsistent with the vast majority of the events' behaviors.)And I need to spend time looking over the rest.
From the original PR (I didn't read the Readme changes as closely as I should have), the top of the Readme says this:
This is not accurate (one example is that
poolStatus
is nowequipmentState
) and should be changed. I don't mind doing that after taking this PR, but wanted to mention it in case it was unintentional.