search

parnikkapore / pe

0 stars 0 forks source link

Overzealous name validation? #2

Open parnikkapore opened 2 years ago

parnikkapore commented 2 years ago

Reproduction instructions

add student n/Amstel-Hofenmeyer s/o Greta Schumann, Sr. III i/A0123456X ph/81234567 e/hi@hello.com tele/amstelh m/CS1234 tut/B1

Expected

The new student is added.

Actual

Names should only contain alphanumeric characters and spaces, and it should not be blank

Yes, some people have names with special characters, and the TA might want to track their students' LumiNUS names...

nus-pe-bot commented 1 year ago

Team's Response

It is impossible for us to accept all the different types of language alphabets. If we were to not impose any restrictions, then even emojis will be accepted.

If the user tries to input any special characters, it fails gracefully and an error message is displayed to inform users of the format accepted.

Overall, it is very rare for a person to have non-alphanumeric characters in their name. However, it is indeed a nice suggestion that we could consider in future iterations.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: Bumped to Low as this is not a cosmetic issue (it has to do with validating names with symbols in them)

While the devs did not sufficiently address the report's concerns (LumiNUS names containing s/o, etc), I agree that this is not important at all in the majority of cases, and the design decision to change from AB3's naming restrictions can happen later.

Considering that accepting emojis in names will not break anything yet, blocking instead of warning will need a justification (e.g. features in the future that won't work properly if the name isn't a pure name).