search

parnikkapore / pe

0 stars 0 forks source link

Error not highlighted on lowercase grade #3

Open parnikkapore opened 2 years ago

parnikkapore commented 2 years ago

Reproduction instructions

add student n/Amstel Hofenmeyer i/A0123456X ph/81234567 e/hi@hello.com tele/amstelh m/CS1234 tut/B1 g/a att/9999999999999999 part/00593

Expected

The command should be highlighted red

Actual

The command reverts to white

(Edit: This is likely to be a duplicate of #4)

nus-pe-bot commented 1 year ago

Team's Response

It is indeed a duplicate. Root cause is the att/9999999999999999

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Grade error message displayed despite it being valid

Reproduction instructions

add student n/Amstel Hofenmeyer i/A0123456X ph/81234567 e/hi@hello.com tele/amstelh m/CS1234 tut/B1 g/A att/9999999999999999 part/00593

Expected

Error message about attendance

Actual

Grade should be A, B, C, D or F. If grade is unavailable, leave as PENDING...

Edit: It's an uncaught error, likely within attendance parsing. The wrong error message was because the results box was not modified.

[original: nus-cs2103-AY2223S1/pe-interim#5523] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This is extreme user behaviour and as stated on the module website:

“If the problems can only happen in case of deliberate sabotage (e.g., user entered a 30-digit telephone number), in which case it should not be considered a bug.”

The user would not have accidentally typed in such a long integer input, as attendance is expected to be a 1 or 2-digit number only.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]

:question: Issue severity

Team chose [severity.Low] Originally [severity.VeryLow]

Reason for disagreement: [replace this with your explanation]