search

parnikkapore / pe

0 stars 0 forks source link

PENDING... is a valid grade value #6

Open parnikkapore opened 2 years ago

parnikkapore commented 2 years ago

Reproduction instructions

edit student 1 g/PENDING...

Expected

Error message about wrong grade format (according to UG, this is not a valid value for g/)

Actual

Grade is set to PENDING...

nus-se-bot commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Cannot clear grade

Reproduction instructions

edit student 1 g/

Expected

Grade is set to PENDING...

(UG:

If nothing is given to GRADE even though g/ is typed into the command box, it will automatically be set to PENDING... .

)

Actual

Grade should be A, B, C, D or F. If grade is unavailable, leave as PENDING...

There is no other way to do this (except for an undocumented way - see other bug), which might justify a Medium, but this is not very common so Low for now

[original: nus-cs2103-AY2223S1/pe-interim#5524] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: Fixing this bug consists of distinguishing between a missing value and the value that otherwise represents a missing value (possibly using Optional.orElse(null)), while the "original" bug can be fixed simply by relaxing the validation condition in certain cases.