search

parnikkapore / pe

0 stars 0 forks source link

No validation for find parameters #8

Open parnikkapore opened 1 year ago

parnikkapore commented 1 year ago

Reproduction instructions

find m/cs5

Expected

Format error about wrong module format, consistent with add

Actual

No results found (which is correct, btw)

The user might expect there to be validation for the inputs for find, as there is one for add and edit students.

soc-pe-bot commented 1 year ago

Team's Response

The reason being our find command is not a full word match, but a partial word match, hence why there is no validation, unlike add and edit commands.

Example: Say if the TA wants to find all the CS coded modules that he teach, he can simply type find/CS

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: > our find command is not a full word match, but a partial word match

Only full words will be matched e.g. Han will not match Hans
~ UG

I agree that this is A) possibly not in scope / deferrable, and B) not very important at all. However, the issue has not been sufficiently addressed by the dev team here.

:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: Bumped to Low as this is not a cosmetic issue (affects behavior on entering the given command)