CMake: Add various fixes to CMakeLists.txt - Githubissues

parnoldx / nasc

Do maths like a normal person

http://parnoldx.github.io/nasc/

GNU General Public License v3.0

560 stars 37 forks source link

CMake: Add various fixes to CMakeLists.txt #108

Closed scx closed 5 years ago

scx commented 5 years ago

CMake: Fix linking

Build app with static library.

Fixes #97 and #103

See also: https://build.opensuse.org/package/view_file/openSUSE:Factory/nasc/nasc-0.5.0-link.patch?expand=1

CMake: Remove --thread option for Vala Compiler

The --thread option is now deprecated. Should be ignored, but actually it leads to a build failure.

See also: https://github.com/GNOME/vala/blob/f7c386eae4a1ab15eb4a21dce540e6298d93436c/compiler/valacompiler.vala#L131

This PR is related to submitting my flatpak package to the Flathub repository. https://github.com/parnold-x/nasc/issues/105 https://github.com/flathub/flathub/pull/867

See also: https://github.com/scx/nasc/pull/3

scx commented 5 years ago

Before reviewing, please read this: https://github.com/parnold-x/nasc/pull/110#issue-253611449