search

parnoldx / nasc

Do maths like a normal person
http://parnoldx.github.io/nasc/
GNU General Public License v3.0
560 stars 37 forks source link

Theme issue on fedora with white-sur #176

Closed aniketfuryrocks closed 3 years ago

aniketfuryrocks commented 3 years ago

Screenshot from 2021-08-17 17-56-36

Gtk theme White Sure Theme

Issue The right pane is not readable Does not seem to be an issue with the theme.

Platform

❯ neofetch            
          /:-------------:\          aniket@fedora
       :-------------------::        -------------
     :-----------/shhOHbmp---:\      OS: Fedora 34 (Workstation Edition) x86_64
   /-----------omMMMNNNMMD  ---:     Host: 81BF Ideapad 520-15IKB
  :-----------sMMMMNMNMP.    ---:    Kernel: 5.13.9-200.fc34.x86_64
 :-----------:MMMdP-------    ---\   Uptime: 6 hours, 55 mins
,------------:MMMd--------    ---:   Packages: 2381 (rpm), 14 (flatpak)
:------------:MMMd-------    .---:   Shell: fish 3.3.1
:----    oNMMMMMMMMMNho     .----:   Resolution: 1600x900, 1920x1080
:--     .+shhhMMMmhhy++   .------/   DE: GNOME 40.3
:-    -------:MMMd--------------:    WM: Mutter
:-   --------/MMMd-------------;     WM Theme: WhiteSur-dark
:-    ------/hMMMy------------:      Theme: WhiteSur-dark [GTK2/3]
:-- :dMNdhhdNMMNo------------;       Icons: WhiteSur-dark [GTK2/3]
:---:sdNMMMMNds:------------:        Terminal: alacritty
:------:://:-------------::          Terminal Font: black: '0x212121'
:---------------------://            CPU: Intel i5-8250U (8) @ 3.400GHz
                                     GPU: Intel UHD Graphics 620
                                     GPU: NVIDIA GeForce MX150
                                     Memory: 4847MiB / 7721MiB
parnoldx commented 3 years ago

Hi, this app is optimized for the elementary theme/os. So your problem is that the theme makes the app dark without the app knowing it. You must assure that the dark_mode boolean is true https://github.com/parnold-x/nasc/blob/master/src/NascSettings.vala#L56 I am open for PRs to handle this on other os if it`s not breaking things.

lobau commented 3 years ago

@parnold-x I forked your app to make it looks better on Gnome (and added a Theme switcher since Gnome doesn't have a global one like Elementary) https://github.com/lobau/napkin If there was a way to support both Elementary and Gnome in the same code base I wouldn't mind tho :-) I renamed the app to match the Gnome HIG better, updated the toolbar icons to use GTK ones, added the theme switcher, and I was going to make a new icon, but I'm not convinced a fork is the way to go. Thoughts on how to support both Elementary and Gnome?

parnoldx commented 3 years ago

Yeah, I am open to add code to support other Environments. But I don't like theme switchers and stuff like that. There must be a better way but I don't know Gnome.

lobau commented 3 years ago

I believe Gnome 42 will have a theme switcher. So far I don't think there is a non-hacky way to know the user's theme