search

parnoldx / timer

The ultimate tea timer
GNU General Public License v3.0
16 stars 6 forks source link

Consider word orders in other languages #22

Closed ryonakano closed 5 years ago

ryonakano commented 5 years ago

I found there is a problem in word orders while I was trying to make the app itself and metadata files (like .appdata.xml or .desktop files) translatable in my forked repository.

Screenshot from 2019-07-20 11-58-15

In the current code, the label in the titlebar changes to <timername> finished when the countdown finished. And then if users restart the timer, the label in the headerbar is back to <timername>. This operation is done by adding/removing the constant string " finished" at the end of timername. This works well in the case of English.

However, in some language this does not work, because in some language word orders are different from English one, thus the changed label should be finished <timername> instead of <timername> finished.

This PR allows translators to change the word order of " finished" and fixes this problem.

ryonakano commented 5 years ago

I decided to centralize on #24 and close this one.