[FLPATH-1277] Remove RHDH's secret from OCP chart

jordigilh commented 6 months ago

Removes the RHDH secret that hosts the GitHub, K8s and ArgoCD credentials.
At templating time, the key existence is validated against the deployed secret rather than validate that the values.yaml entry contains a value. This ensures that the snippets of code that are currently embedded based on the secret's key existence in the values.yaml file remain consistent with the new change.
Rebuilt the README.md using frigate following the instructions in the documentation.
Note that with this change, the chart will fail to deploy if the RHDH secret does not exist or it does not contain the backstage's backend secret (BACKEND_SECRET), which is the only mandatory entry required in the secret.

@masayag PTAL.

masayag commented 6 months ago

Overall, it looks good, but I would like to merge it with the doc PR which I had comments for. We can extend this PR to modify https://github.com/parodos-dev/orchestrator-helm-chart/blob/main/hack/setenv.sh to create the secret

masayag commented 6 months ago

@jordigilh pls bump the version in Chart.yaml to enable its release.

jordigilh commented 6 months ago

@jordigilh pls bump the version in Chart.yaml to enable its release.

Done! 😄

parodos-dev / orchestrator-helm-chart