search

parodos-dev / orchestrator-helm-chart

Helm chart to deploy the Orchestrator solution suite.
https://parodos.dev/orchestrator-helm-chart/
Apache License 2.0
2 stars 22 forks source link

FLPATH-1297: docs: following instructions for deploying without cloning the repo won't work #175

Closed jordigilh closed 6 months ago

jordigilh commented 6 months ago

Add reference in documentation to install the chart via helm repo as well as cloning the git repository (already there)

@masayag @pkliczewski @batzionb PTAL.

batzionb commented 6 months ago

We need instructions for running the setup script without cloning the repo in step 8 perhaps with wget?

jordigilh commented 6 months ago

We need instructions for running the setup script without cloning the repo in step 8 perhaps with wget?

~I think whoever is going to do this should be seasoned enough to figure this much out. After all there's a plethora of options: wget, curl, ~tar.gz~zip from the UI and finally clone. If the user wants to play with the charts, then let them do it their own way. If they need to ask how they can run helm install/upgrade -i using a local copy I think they're not ready to make changes to the charts directly.~

(Apologies for misunderstanding your comment).

I'll take a look next. I think you opened a bug for this, right?

batzionb commented 6 months ago

We need instructions for running the setup script without cloning the repo in step 8 perhaps with wget?

~I think whoever is going to do this should be seasoned enough to figure this much out. After all there's a plethora of options: wget, curl, ~tar.gz~zip from the UI and finally clone. If the user wants to play with the charts, then let them do it their own way. If they need to ask how they can run helm install/upgrade -i using a local copy I think they're not ready to make changes to the charts directly.~

(Apologies for misunderstanding your comment).

I'll take a look next. I think you opened a bug for this, right?

Thanks @jordigilh! I put the two issues in the same bug but it can be two separate PRs https://issues.redhat.com/browse/FLPATH-1297

jordigilh commented 6 months ago

We need instructions for running the setup script without cloning the repo in step 8 perhaps with wget?

Yep, wget is the best candidate. Can you look at the last commit and let me know what you think? I chose explicitly to download the script locally and then run it rather than just /bin/bash -c "$(curl -fsSL ... which could make some people nervous to run a script without looking at its contents first 😄