search

parodos-dev / orchestrator-helm-chart

Helm chart to deploy the Orchestrator solution suite.
https://parodos.dev/orchestrator-helm-chart/
Apache License 2.0
2 stars 22 forks source link

[FLPATH-1297] Change setup.sh to allow non argocd deployments #178

Closed jordigilh closed 4 months ago

jordigilh commented 4 months ago

Changes the hack/setup.sh so that it now will succeed even if no argocd is found in the cluster. This change allows to run the script to generate the backstage secret for non-GitOps environments and removes the necessity in the installation process to specify a different path for non-GitOps environments.

Additionally, the secret created will contain only those keys that have been populated, thus avoiding secrets with keys with empty values.

Links to https://github.com/parodos-dev/orchestrator-helm-chart/pull/175 @batzionb @masayag @pkliczewski PTAL.

batzionb commented 4 months ago

/lgtm

jordigilh commented 4 months ago

Note that the script captures the K8s fields if the user has an authenticated connection with a cluster. Is this behavior acceptable @masayag? This means that the backstage's k8s plugin will be available as part of the RHDH deployment: https://github.com/parodos-dev/orchestrator-helm-chart/blob/197b069d45cc8399b2a52b6c0104ad93d2869983/charts/orchestrator/templates/rhdh-operator.yaml#L111

I'm asking because the existing "manual" setup did not include k8s configuration as part of the secret creation, but now it would automatically.