search

parodos-dev / orchestrator-helm-chart

Helm chart to deploy the Orchestrator solution suite.
https://parodos.dev/orchestrator-helm-chart/
Apache License 2.0
2 stars 22 forks source link

Add section to configure when operator full knative #207

Closed gabriel-farache closed 1 week ago

gabriel-farache commented 3 months ago

Closes https://issues.redhat.com/browse/FLPATH-1406 Add section to configure when operator full knative

Related to https://github.com/parodos-dev/serverless-workflows-config/pull/375

gabriel-farache commented 3 months ago

/hold until https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/467 is merged and chart is updated with operator version with the feature

gabriel-farache commented 2 months ago

@masayag

We agreed not incorporate the Kafka related configuration into the chart, but perhaps patching the sonataflowplatform can be considered

What is related to kafka that should be in the sonataflowplatform? In the readme, we are already patching it for the broker: https://github.com/parodos-dev/orchestrator-helm-chart/pull/207/files#diff-75c29d9ec0c1a79cafdacdbbebff3ea3fa3d649f1b43440783208b21845238dcR61-R76

masayag commented 2 months ago

@masayag

We agreed not incorporate the Kafka related configuration into the chart, but perhaps patching the sonataflowplatform can be considered

What is related to kafka that should be in the sonataflowplatform? In the readme, we are already patching it for the broker: https://github.com/parodos-dev/orchestrator-helm-chart/pull/207/files#diff-75c29d9ec0c1a79cafdacdbbebff3ea3fa3d649f1b43440783208b21845238dcR61-R76

I was trying to explore the option to incorporate this patch into the orchestrator chart, but we can start without having it included.

gabriel-farache commented 2 months ago

was trying to explore the option to incorporate this patch into the orchestrator chart, but we can start without having it included.

The issue here is that the broker name depends on the user We could also include all the steps to the orchestrator directly (installing the knative resource for kafka, creating and configuring the kafka broker and patchin the sonataflowplateform) if the user asks for it

But that should be another issue

masayag commented 2 weeks ago

pls reopen this PR in https://github.com/parodos-dev/orchestrator-helm-operator

masayag commented 1 week ago

@gabriel-farache this PR needs to be closed and reopened against https://github.com/parodos-dev/orchestrator-helm-operator

gabriel-farache commented 1 week ago

@masayag I know I know, it's on my TODO list, but it's not top priority as the PR is still in progress

gabriel-farache commented 1 week ago

@masayag , there I did it, now we have 0 PR on this repo :)

masayag commented 1 week ago

@masayag , there I did it, now we have 0 PR on this repo :)

thanks @gabriel-farache, now there are also 0 issues ;-)