parodos-dev / orchestrator-helm-chart

Helm chart to deploy the Orchestrator solution suite.
https://parodos.dev/orchestrator-helm-chart/
Apache License 2.0
2 stars 22 forks source link

Feat: add SSO IDP connection #225

Closed eloycoto closed 2 months ago

eloycoto commented 2 months ago

Waiting for staging-rc branch to get merged.

Pending:

Two commits:

masayag commented 2 months ago

@eloycoto staging-rc was merged to main, pls rebase this PR on top of the main branch. I assume you'll have to close this one first, therefore I'll wait with adding review comments to the PR on top of main.

rgolangh commented 2 months ago

This change proposed the addition of another plugin, we mainly want for QE and test and have a huge impact on the code, a lot of additions, more values, changes in app-config and so on. Conceptually it belong to its own chart, and actually be maintained by the keycloak plugin authors themself . We can't bundle evertything we want into the chart without expecting serious overhead. Already the chart is quite big and suffisticated. The model of this chart is installing the orchestrator plugin. It should be the same for other plugin, they need to come up with their own ways to be added nicely into a running RHDH, specially when those plugins have their dependencies to mange - what orchestrator if for sonata, keyclock plugin is for keyclock instance. If they keyclock plugin maintainer didn't come up with their own installation method yet then I think they shoud, and perhaps we could even push this work as a seperate chart and propose it

eloycoto commented 2 months ago

based on comments, close this PR.