search

parodos-dev / serverless-workflow-examples

Apache License 2.0
0 stars 13 forks source link

move2kube workflow using ssh keys instead of token #15

Closed gabriel-farache closed 5 months ago

gabriel-farache commented 6 months ago

Follow-up of #8

This PR changes the way the workflow and the move2kube instance interact with the private git repo: instead of using a token, they are using ssh keys previously added to the account (ie: https://bitbucket.org/account/settings/ssh-keys/)

By using the ssh keys, the move2kube instance can clone the repository when creating a plan. Thus, enabling the workflow to use the remote-source query param and removing the need for the CreatePlan Knative function.

Once https://github.com/konveyor/move2kube/pull/1126 is merged, we can revert back to using the konveyor images

Solves https://issues.redhat.com/browse/FLPATH-820

pkliczewski commented 5 months ago

/lgtm

pkliczewski commented 5 months ago

@masayag please review and merge