search

parodos-dev / serverless-workflow-examples

Apache License 2.0
0 stars 13 forks source link

FLPATH-970: restructure assessment with other options #30

Closed anludke closed 3 months ago

anludke commented 3 months ago

This PR structures the assessment as a whole providing 3 different examples of implementing an assessment workflow using (1) jq expression, (2) custom code and (3) knative function to perform the assessment per se and then return infrastructure workflow options based on a simple use case. Indeed, the assessment here requires a user input as a string and checks if it it contains the keyword dummy in order to recommend the suitable infrastructure workflow options. The goal here is the provides different options to developers to start writing assessment workflows for the orchestrator.

masayag commented 3 months ago

@anludke Please provide a meaningful commit description to enable the review for this PR

dmartinol commented 3 months ago

I had a quick look at it but, due to the huge number of files and the fat that these are new examples added to the repo, instead of validating these changes on my repo I'd suggest to have a meeting where you can show live the workflow runtime. WDYT? FYI @masayag

pkliczewski commented 3 months ago

@anludke @masayag @dmartinol have we had the meeting to talk about this PR? or is it ok to continue review?

dmartinol commented 3 months ago

@anludke @masayag @dmartinol have we had the meeting to talk about this PR? or is it ok to continue review?

It's fine for me even with no meeting, but I'll leave the last word to @masayag

masayag commented 3 months ago

Add minor comments, other than that, LGTM.

anludke commented 3 months ago

another quick look. \lgtm but I would add brief explanation of how these implementation are different. apart from that, well done

Brief explanation added to each implementation