search

parodos-dev / serverless-workflow-examples

Apache License 2.0
0 stars 13 forks source link

Checking in the serverless workflow example to perform workflow chain… #5

Closed lokeshrangineni closed 3 months ago

lokeshrangineni commented 9 months ago

Checking in the serverless workflow example to perform workflow chaining using SubFlowRef definition

gabriel-farache commented 9 months ago

could you add the target repository to the .gitignore file please?

lokeshrangineni commented 9 months ago

could you add the target repository to the .gitignore file please?

good catch. added the .gitignore file. Added target directory to it.

gabriel-farache commented 9 months ago

Minor comments but looks good overall

lokeshrangineni commented 9 months ago

Recently I reviewed assessment design and I wonder how you handle workflow validation. How do we know that all the sub-workflows/ chained workflows are available in the environment and whether the user has a permission to execute it?

It seems to be big issue for assessments and I wonder how we should handle it for this use case.

We touched briefly on this topic, on the Jira. It will fall under the authorization/authentication of the services section. All the services can have OAuth or JWT based authentication/authorization.

lokeshrangineni commented 9 months ago

Why there is the need of the subfolder serverless-workflow-order-processing? Are you planning to add more examples?

I thought of adding more related to the parallel workflow but I can that into its own directory. Moved the project now.

pkliczewski commented 9 months ago

/lgtm

pkliczewski commented 9 months ago

@gabriel-farache is there anything you would like to change in this PR?

gabriel-farache commented 9 months ago

/lgtm

gabriel-farache commented 8 months ago

/lgtm

openshift-ci[bot] commented 8 months ago

New changes are detected. LGTM label has been removed.

pkliczewski commented 7 months ago

@lokeshrangineni will you continue to work on this PR?

lokeshrangineni commented 7 months ago

I missed following up on this PR. Apologies. I will take a look at it next week.

masayag commented 3 months ago

Closing since not being updated for ~4 months. Some of the dependencies are outdated and this isn't expected to work.